Fix executeQuery default return type
#1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The executeQuery method was returning `Promise<unknown` when no transformer or typing was provided like in the example bellow:
```
// works
const { records } = await driver.executeQuery<EegerResult>(`query`)
// works
const { records }: EagerResult = await driver.executeQuery(`query`)
// doesn't work, but it is fixed by this change
const { records } = await driver.executeQuery(`query`)
```
Defining a default generic type solves the issue.
fbiville
approved these changes
Jan 31, 2023
| @@ -342,6 +342,32 @@ describe('Driver', () => { | |||
| }, query, params) | |||
| }) | |||
|
|
|||
| it('should be able to destruct the result in records, keys and summary', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should be able to destruct the result in records, keys and summary', async () => { | |
| it('should be able to destructure the result in records, keys and summary', async () => { |
bigmontz
added a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Mar 6, 2023
The executeQuery method was returning `Promise<unknown` when no transformer or typing was provided like in the example bellow:
```
// works
const { records } = await driver.executeQuery<EegerResult>(`query`)
// works
const { records }: EagerResult = await driver.executeQuery(`query`)
// doesn't work, but it is fixed by this change
const { records } = await driver.executeQuery(`query`)
```
Defining a default generic type solves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executeQuery method was returning
Promise<unknown>when no transformer or typing was provided like in the example bellow:Defining a default generic type solves the issue.